Differential D15299

Disable pixel grid if OpenGL is disabled
ClosedPublic
Actions

Authored by arukuka on Sep 5 2018, 5:32 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:9d0a1bba3d5b: Disable pixel grid action of opengl is disabled
R37:b19baf642605: Disable pixel grid action of opengl is disabled
Summary

BUG: 388903

I thought that following change is one way to fix it.

  • adds ActivationCondition for disabling the action
  • sets the action unchecked if OpenGL is disabled

However, I am not sure that it is acceptable way.
I was wondering if you could check diffs.

Before

After

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arukuka requested review of this revision.Sep 5 2018, 5:32 PM
arukuka created this revision.
rempt accepted this revision.Sep 6 2018, 8:49 AM
rempt added a subscriber: rempt.

I've tested it and it works correctly. Do you have push access?

This revision is now accepted and ready to land.Sep 6 2018, 8:49 AM
arukuka added a comment.Sep 6 2018, 9:16 AM
In D15299#321226, @rempt wrote:

I've tested it and it works correctly.

Thank you!

In D15299#321226, @rempt wrote:

Do you have push access?

No, I don't have that.

rempt added a comment.Sep 6 2018, 9:22 AM

Okay, I'll push it.

Closed by commit R37:9d0a1bba3d5b: Disable pixel grid action of opengl is disabled (authored by rempt). · Explain WhySep 6 2018, 9:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41093

View Options

krita/kritamenu.action

Loading...
View Options

libs/ui/KisViewManager.cpp

Loading...
View Options

libs/ui/kis_action.h

Loading...
View Options

libs/ui/kis_action_manager.cpp

Loading...