Differential D15298

fix handling of baloo starting after elisa
ClosedPublic
Actions

Authored by mgallien on Sep 5 2018, 3:39 PM.

Details

Reviewers
astippich
januz
aspotashev
Commits
R255:77d5946c660f: fix handling of baloo starting after elisa
Summary

if Baloo is configured inactive at elisa start and later is enabled,
fix baloo management such that we correctly query Baloo for a list of
audio files

BUG: 387437

Test Plan

manual test allow to get the music files from baloo

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Sep 5 2018, 3:39 PM
mgallien created this revision.
astippich added a comment.Sep 13 2018, 5:11 PM

I can't reproduce. What's the exact test plan?

mgallien added a comment.Sep 13 2018, 6:06 PM
In D15298#325370, @astippich wrote:

I can't reproduce. What's the exact test plan?

You can have a look at the attached bug. The procedure is easy to follow.

astippich added a comment.Sep 13 2018, 6:55 PM

I already did that, and in both cases tracks showed up. will try once more

mgallien added a comment.Sep 13 2018, 7:09 PM
In D15298#325421, @astippich wrote:

I already did that, and in both cases tracks showed up. will try once more

Did you remove your music database before doing the test ?

astippich added a comment.Sep 13 2018, 7:33 PM

yes, elisa does not show any tracks first, but if baloo is enabled they start to appear

astippich accepted this revision.Sep 13 2018, 7:44 PM

okay, wiped everything and retried, works now and this patch fixes the bug

This revision is now accepted and ready to land.Sep 13 2018, 7:44 PM
Closed by commit R255:77d5946c660f: fix handling of baloo starting after elisa (authored by mgallien). · Explain WhySep 13 2018, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41577

View Options

src/CMakeLists.txt

Loading...
View Options

src/baloo/localbaloofilelisting.h

Loading...
View Options

src/baloo/localbaloofilelisting.cpp

Loading...