Differential D15291

[Folder View] Compare UDS entry times directly instead of going through KFileItem
ClosedPublic
Actions

Authored by broulik on Sep 5 2018, 11:28 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:2d008a5b931a: [Folder View] Compare UDS entry times directly instead of going through…
Summary

This avoids creating a QDateTime object with all the timezone processing that comes with it since we're only interested in the relative order, not absolute precise date time values.

CHANGELOG: Sorting files by date in Folder View is significantly faster now

Test Plan

Having my Downloads ordner as FV sorted ascending by date went from 60ms to under 1ms
Files still appear sorted correctly
Did the same change in Dolphin a while back

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 5 2018, 11:28 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 5 2018, 11:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 5 2018, 11:28 AM
hein accepted this revision.Sep 5 2018, 4:40 PM
This revision is now accepted and ready to land.Sep 5 2018, 4:40 PM
Closed by commit R119:2d008a5b931a: [Folder View] Compare UDS entry times directly instead of going through… (authored by broulik). · Explain WhySep 6 2018, 7:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41085

View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...