Differential D15289

Use lambda instead of QSignalMapper
ClosedPublic
Actions

Authored by volkov on Sep 5 2018, 11:00 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R111:fe44c73bd32e: Use lambda instead of QSignalMapper
Summary

QSignalMapper is obsolete and the code with lambda is shorter and clearer.

Diff Detail

Repository
R111 KSysguard Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2525
Build 2543: arc lint + arc unit
volkov created this revision.Sep 5 2018, 11:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 5 2018, 11:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
volkov requested review of this revision.Sep 5 2018, 11:00 AM
broulik added a subscriber: broulik.Sep 5 2018, 11:03 AM
broulik added inline comments.
processui/ksysguardprocesslist.h
49 ↗(On Diff #41043)

That class is exported, so changing method signatures will be ABI-incompatible. Not sure how many guarantees we give for libksysguard but I would still prefer to keep breakages to a minimum.

You could just keep the qobject_cast

volkov updated this revision to Diff 41045.Sep 5 2018, 11:27 AM

revert change of actionTriggered's signature

broulik accepted this revision.Sep 5 2018, 12:02 PM
This revision is now accepted and ready to land.Sep 5 2018, 12:02 PM
volkov closed this revision.Sep 5 2018, 12:22 PM

Revision Contents
Changeset List

PathPackages
Mprocessui/ksysguardprocesslist.cpp (6 lines)

Diff 41045

View Options

processui/ksysguardprocesslist.cpp

Loading...