Differential D15283

Move SMB KCM to Network Settings category
ClosedPublic
Actions

Authored by broulik on Sep 5 2018, 7:34 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
VDG
Commits
R241:ace6f726eaf5: Move SMB KCM to Network Settings category
Summary

The "Connectivity" category is empty and makes it show up on the root level as non-descript "Connectivity" entry

Test Plan

Before


After

Every other KIO KCM is also in that category

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 5 2018, 7:34 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 5 2018, 7:34 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sep 5 2018, 7:34 AM
ngraham added a subscriber: ngraham.Sep 5 2018, 3:02 PM

Makes sense, but can we just delete this KCM entirely instead? Apparently it doesn't, um, work. https://bugs.kde.org/show_bug.cgi?id=164283

broulik added a comment.Sep 5 2018, 3:02 PM

I investigated once but the SMB kio slave actually still reads these properties. Why it doesn't work, I have no idea. SMB browsing is completely broken in newer distros thanks to switch to SMB >= 2 ..

ngraham accepted this revision as: VDG.Sep 5 2018, 3:03 PM

OK, for now let's move it to the proper place then.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 7 2018, 7:16 AM
Closed by commit R241:ace6f726eaf5: Move SMB KCM to Network Settings category (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcms/kio/smb.desktop (2 lines)

Diff 41132

View Options

src/kcms/kio/smb.desktop

Loading...