Differential D15280

Code Cleanup
ClosedPublic
Actions

Authored by rizzitello on Sep 5 2018, 12:32 AM.

Details

Reviewers
laysrodrigues
leandrosantiago
tcanabrava
patrickelectric
Commits
R232:858b5273799c: Use int32_t for baud
R232:bab4fc1a4df3: Use int for progressBar progress
R232:d21c892fd6b3: SerialTimerInterval now int
R232:95cf2e6d4578: Remove unneeded semicolons and update documents incorrect data
R232:7d97866c96e1: Remove unused object from lambda
R232:796a83c35705: Code Cleanup
R232:52b54195cbd1: Remove double referance
R232:ef6cb93af7ba: Remove unneeded semicolons
Summary

Clean up some type conversion warnings and other small warnings.

  • Use int32_t for baud
  • SerialTimerInterval now int
  • Remove unneeded semicolons
  • Remove unused object from lambda
  • Remove unneeded semicolons and update documents incorrect data
  • Use int for progressBar progress
  • Remove double referance

Diff Detail

Repository
R232 AtCore
Branch
warningCleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2528
Build 2546: arc lint + arc unit
rizzitello requested review of this revision.Sep 5 2018, 12:32 AM
rizzitello created this revision.
rizzitello retitled this revision from Summary: Clean up some type conversion warnings and other small warnings. to Code Cleanup.Sep 5 2018, 12:33 AM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added reviewers: laysrodrigues, leandrosantiago, tcanabrava, patrickelectric.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
patrickelectric requested changes to this revision.Sep 5 2018, 12:44 AM
patrickelectric added inline comments.
src/core/seriallayer.h
79

uint32_t

This revision now requires changes to proceed.Sep 5 2018, 12:44 AM
rizzitello marked an inline comment as done.Sep 5 2018, 12:46 AM
rizzitello added inline comments.
src/core/seriallayer.h
79

QSerialPort::setBaud takes a qint32 this removes the warning for the conversion to uint

http://doc.qt.io/qt-5/qserialport.html#baudRate-prop

rizzitello updated this revision to Diff 41049.Sep 5 2018, 12:06 PM
rizzitello marked an inline comment as done.
  • Use int32_t for baud
patrickelectric accepted this revision.Sep 5 2018, 12:10 PM
This revision is now accepted and ready to land.Sep 5 2018, 12:10 PM
rizzitello marked an inline comment as done.Sep 6 2018, 12:00 AM
rizzitello edited the summary of this revision. (Show Details)Sep 6 2018, 10:55 AM
tcanabrava accepted this revision.Sep 14 2018, 9:22 PM
laysrodrigues accepted this revision.Sep 14 2018, 9:25 PM
rizzitello closed this revision.Sep 15 2018, 12:10 AM

Revision Contents
Changeset List

Diff 41049

View Options

src/core/atcore.h

Loading...
View Options

src/core/atcore.cpp

Loading...
View Options

src/core/gcodecommands.h

Loading...
View Options

src/core/seriallayer.h

Loading...
View Options

src/core/seriallayer.cpp

Loading...
View Options

src/widgets/logwidget.cpp

Loading...
View Options

src/widgets/movementwidget.h

Loading...
View Options

src/widgets/plotwidget.h

Loading...
View Options

src/widgets/statuswidget.h

Loading...
View Options

src/widgets/statuswidget.cpp

Loading...