Ping.

In D15275#323311, @davidedmundson wrote:

As you're doing the common fix for QRect::right/bottom fix would it be cleaner to just use a QRectF for the area and then kill all the +1s?

Yes, it would. But then we would mix QRectF's and QRect's. Nah, that's a can of worms. Can we push it as it is right now(this diff pretty much corrects existing calculations) and revisit this in the future?

I struggle to see how

QRectF areaF = area;
inside the one block where we make the vertices is a "can of worms". It's scarcely even one worm.

but you have this approved, do whichever.

In D15275#323330, @davidedmundson wrote:

I struggle to see how

QRectF areaF = area;
inside the one block where we make the vertices is a "can of worms". It's scarcely even one worm.

but you have this approved, do whichever.

Well, we have area and areaF, which is not really clean. It would be cleaner to use type of QRectF for area, but then things become ugly. Anyway, I'll do your way.

I'll adjust the commit message on push.