We have to adjust only QRect::right and QRect::bottom, QRect::left and QRect::top are okay.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:617b4d92fa54: [effects/magnifier] Fix 1 px gap between magnified area and frame
Before:
After:
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- effects-magnifier-fix-1px-gaps
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2501 Build 2519: arc lint + arc unit
Comment Actions
As you're doing the common fix for QRect::right/bottom fix would it be cleaner to just use a QRectF for the area and then kill all the +1s?
Comment Actions
Yes, it would. But then we would mix QRectF's and QRect's. Nah, that's a can of worms. Can we push it as it is right now(this diff pretty much corrects existing calculations) and revisit this in the future?
Comment Actions
I struggle to see how
QRectF areaF = area;
inside the one block where we make the vertices is a "can of worms". It's scarcely even one worm.
but you have this approved, do whichever.
Comment Actions
Well, we have area and areaF, which is not really clean. It would be cleaner to use type of QRectF for area, but then things become ugly. Anyway, I'll do your way.