[Folder View] Use KIO::PreviewJob::defaultPlugins() for default plugins
ClosedPublic

Authored by broulik on Sep 4 2018, 2:32 PM.

Details

Summary

Rather than a hardcoded list of only two thumbnailers.
All of this is done under the hood so the QML part doesn't need to be changed.
This is the same behavior as Dolphin uses, when the list of thumbnailers is empty, the default set (which includes all thumbnailers except textthumbs) is used.

Test Plan

Before


After

  • Verified that all the thumbnails are shown
  • Verified that the previewer config dialog has the correct plugins checked
  • Verified that changing the previewer config updates the thumbnails and has the setting stored, execpt when the default set of previews is enabled, nothing is stored so that when defaultPlugins would change, it is picked up automatically

I don't exactly know why the ttf thumbnail looks different from Dolphin where it is just a couple of letters instead of a full sentence

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 4 2018, 2:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 4 2018, 2:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 4 2018, 2:32 PM
ngraham added a subscriber: ngraham.Sep 5 2018, 3:36 AM

+1 for the result!

hein accepted this revision.Sep 5 2018, 8:54 AM
This revision is now accepted and ready to land.Sep 5 2018, 8:54 AM
This revision was automatically updated to reflect the committed changes.