Reduce differences between KSaneScanThread and KSanePreviewThread
ClosedPublic

Authored by volkov on Sep 4 2018, 1:25 PM.

Details

Summary
  • reorder member variables
  • move KSaneScanThread::scanProgress() to the corresponding place
  • use the same code to invert colors

Diff Detail

Repository
R382 KSane Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2493
Build 2511: arc lint + arc unit
volkov requested review of this revision.Sep 4 2018, 1:25 PM
volkov created this revision.
volkov added a reviewer: sars.Sep 4 2018, 1:26 PM
sars accepted this revision.Sep 5 2018, 6:09 AM

Looks good to me...

The inversion of 16bit colors looks like it fixes a bug.

I have a vague memory that I had a 8bits/color limit implemented for preview but the only thing left of that seems to be the m_optDepth->storeCurrentData(); and m_optDepth->restoreSavedData();...

Thanks,

Kåre
This revision is now accepted and ready to land.Sep 5 2018, 6:09 AM
volkov closed this revision.Sep 5 2018, 12:17 PM