Differential D15261

Remove XRandrBrightness
ClosedPublic
Actions

Authored by broulik on Sep 4 2018, 8:36 AM.

Details

Reviewers
bshah
graesslin
Group Reviewers
Plasma
Commits
R122:7e2986932918: Remove XRandrBrightness
Summary

It doesn't work on Wayland and was from what I recall only supported by the long disused Intel driver.

Test Plan
  • Compiles, been using it on my laptop for a while with no problem
  • Some more testing, nvidia, amd?

Diff Detail

Repository
R122 Powerdevil
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 4 2018, 8:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 4 2018, 8:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 4 2018, 8:36 AM
bshah added a comment.Sep 7 2018, 7:52 AM

FWIW, as mentioned on IRC, +1, kill it with 🔥

graesslin accepted this revision.Sep 7 2018, 10:23 AM
This revision is now accepted and ready to land.Sep 7 2018, 10:23 AM
Closed by commit R122:7e2986932918: Remove XRandrBrightness (authored by broulik). · Explain WhySep 7 2018, 10:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40965

View Options

CMakeLists.txt

Loading...
View Options

daemon/backends/CMakeLists.txt

Loading...
View Options

daemon/backends/upower/powerdevilupowerbackend.h

Loading...
View Options

daemon/backends/upower/powerdevilupowerbackend.cpp

Loading...
View Options

daemon/backends/upower/xrandrbrightness.h

Loading...
View Options

daemon/backends/upower/xrandrbrightness.cpp

Loading...
View Options

daemon/backends/upower/xrandrxcbhelper.h

Loading...
View Options

daemon/backends/upower/xrandrxcbhelper.cpp

Loading...