Otherwise for 22px icons on high dpi we will request either the wrong icons or scale them needlessly.
Dolphin requests a pixmap of 22px, this is then multiplied by dpr resulting in 44 which isn't a valid icon size (only 32 or 48 are). Moreover, we will also hit the path where it will scale the pixmap to a proper icon size resulting in blurry icons (and a performance penalty).
Details
Details
- Reviewers
elvisangelaccio ngraham - Group Reviewers
Dolphin - Commits
- R318:1e7e4fad49e9: [KStandardItemListWidget] Round to icon size before applying scaling
stable branch
Before
After
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
A big improvement! Works great and doesn't seem to cause any regressions that I could detect in either 1x or 2x. Fractional scaling is still broken due to https://bugs.kde.org/show_bug.cgi?id=396990, of course. While you're fixing HiDPI stuff, wanna take a look at that one?