Show tooltips in krunner
Needs ReviewPublic

Authored by McPain on Sep 3 2018, 2:59 PM.

Details

Reviewers
broulik
ngraham
mart
Group Reviewers
Plasma
Summary

In case of something long in krunner you can't read the whole string because of one line restriction and fixed krunner width.

This patch enables tooltips where you can read anything krunner shows.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Sep 3 2018, 2:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 3 2018, 2:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Sep 3 2018, 2:59 PM
ngraham requested changes to this revision.Sep 4 2018, 3:11 AM
ngraham added reviewers: Plasma, broulik.
ngraham added a subscriber: ngraham.

The patch does not apply because of an extraneous milou in the path for your diff:

milou/lib/qml/ResultDelegate.qml
should be
lib/qml/ResultDelegate.qml

Consider setting up arc; it makes the patch submission process so much simpler and less error-prone. :)

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

This revision now requires changes to proceed.Sep 4 2018, 3:11 AM
McPain updated this revision to Diff 40956.Sep 4 2018, 7:29 AM
McPain added a comment.Sep 4 2018, 1:02 PM

The patch does not apply because of an extraneous milou in the path for your diff:

Consider setting up arc; it makes the patch submission process so much simpler and less error-prone. :)

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Also, I don't have arcanist in my repo (I'm using ALT linux)

ngraham set the repository for this revision to R112 Milou.Sep 4 2018, 1:47 PM

Thanks, the patch applies now.

Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names are elided in KRunner.

McPain added a comment.Sep 5 2018, 6:57 AM

Thanks, the patch applies now.

Can you verify that this works for you? When I apply the patch (and reboot for good measure), I still don't see tooltips for items whose names are elided in KRunner.

It works for me

Found out that sometimes displayed text appears to be elided (not always reproducible)
Resolution: 1920x1080, dpi: 142

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

abetts added a subscriber: abetts.Oct 13 2018, 1:48 PM

Love it!

Thanks for the patch!

McPain added a comment.EditedOct 15 2018, 7:18 AM

Any ideas how to fix the bugs I mentioned above, please?

mart accepted this revision.Nov 23 2018, 2:37 PM
mart added a subscriber: mart.

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

there was a recent fix in the kwin morphingpopup effect that should have fixed it, i would say go for it

In D15247#364814, @mart wrote:

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

there was a recent fix in the kwin morphingpopup effect that should have fixed it, i would say go for it

Hi. I don't see any

In D15247#364814, @mart wrote:

Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386}

there was a recent fix in the kwin morphingpopup effect that should have fixed it, i would say go for it

It was commit b257029afc3bfcd6366d2c2b910b8d91403ab8aa from plasma-framework
@ngraham what could you say about patch?

I am still not actually getting any tooltips when I hover over an elided entry.

I am still not actually getting any tooltips when I hover over an elided entry.

strange

I am still not actually getting any tooltips when I hover over an elided entry.

strange

IMO what's seen in your screenshot is not useful behavior. If the full text fits in the regular UI, there's no need to show a tooltip; it's just redundant.

McPain added a comment.Jun 3 2019, 9:31 AM

IMO what's seen in your screenshot is not useful behavior. If the full text fits in the regular UI, there's no need to show a tooltip; it's just redundant.

I see. Somehow subTextLabel.truncated is always true