There's no point in creating a QFileInfo instance and checking for file properties if we're not going to do anything with it when not inside home
Details
Details
- Reviewers
elvisangelaccio lbeltrame - Group Reviewers
Dolphin - Commits
- R318:7ec783e7493a: [ViewProperties] Check part of home first before doing file system stuff
- Accessing a slow or stale mount in /run/user/foo/bar no longer blocks here and is a nice simple optimization anyway imho
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I don't understand well the is part of home stuff, do you mean checking for things out of /home?
Comment Actions
From what I understand if the file is not inside /home/user then it will not even try writing into the .directory file of a folder but always save it in Dolphin's config folder
| src/views/viewproperties.cpp | ||
|---|---|---|
| 71–73 | I'd just remove these comments, because they are a bit confusing (and we already have a better comment at the top of the if-else chain). | |