Add missing dependencies in CMakeLists.txt

Authored by dcaliste on Sep 3 2018, 10:10 AM.



Add missing dependencies in target_link_libraries() cmake macro here and there. Added dependencies comes from #include<> directives for specific headers, like for instance having #include<kmessagebox.h> but not specifying KF5::WidgetsAddons.

I'm still a bit puzzled how it can compile without these modifications since required '-I path' compiler options are then missing… Maybe because I'm using non standard pathes for compilation.

Additionally, I've moved the add_includedirs() macro in sheets/CMakeLists.txt inside the ifdef PART_SHEETS, otherwise the eigen3 include directory variable may not be set, when configuring without part_sheets and cmake fails in that case.

Diff Detail

R8 Calligra
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dcaliste created this revision.Sep 3 2018, 10:10 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptSep 3 2018, 10:10 AM
dcaliste requested review of this revision.Sep 3 2018, 10:10 AM
dcaliste edited the summary of this revision. (Show Details)
leinir accepted this revision.Sep 3 2018, 11:15 AM

Always did like a bit of build system tidying - thanks! :)

This revision is now accepted and ready to land.Sep 3 2018, 11:15 AM
This revision was automatically updated to reflect the committed changes.