Check against QRect whether pointer is inside DecorationButton
ClosedPublic
Actions

Authored by zzag on Sep 2 2018, 9:45 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

Summary

If several buttons share an edge, i.e. spacing between decoration
buttons is set to 0, and the pointer is on that edge, both buttons will
be hovered.

This happens because QRectF::contains returns true for points that are
on "outer" edges, e.g.

QRectF rect(0, 0, 10, 10);
rect.contains(QPointF(10, 5)); // returns true

Test Plan

Ran tests.

Repository

R129 Window Decoration Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

zzag requested review of this revision.Sep 2 2018, 9:45 PM

Add test

zzag edited the test plan for this revision. (Show Details)Sep 3 2018, 9:53 AM

zzag added a reviewer: KWin.

would adding

bool DecorationButton::contains(QPoint) const

make sense?

src/decoration.cpp
386	Missed one

This revision is now accepted and ready to land.Sep 3 2018, 10:05 AM

In D15226#319409, @davidedmundson wrote:

would adding

bool DecorationButton::contains(QPoint) const

make sense?

Yes, it would. I'll add this method. :-)

Add contais method

thanks

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/decorationbuttontest.cpp (33 lines)
M			src/decoration.cpp (4 lines)
M			src/decorationbutton.h (5 lines)
M			src/decorationbutton.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40876	42a3bae		Sep 2 2018, 9:45 PM	★	★
Diff 2	40900	42a3bae	Add test	Sep 3 2018, 9:52 AM	★	★
Diff 3	40905	42a3bae	Add `contais` method	Sep 3 2018, 10:35 AM	★	★
Diff 4	40909	42a3bae	R129:c9cfd840137b65bc7391f301f4f63da6df9de859	Sep 3 2018, 11:52 AM	★	★