Set the tick interval, because the default value is 0
ClosedPublic

Authored by ltoscano on Sep 2 2018, 6:27 PM.

Details

Summary

With this change the time is correctly updated also when using
the VLC backend.
It worked for some reason with phonon-gstreamer, but it looks like
it's just by accident. In fact, according the documentation, the default
value of the property is 0:
https://api.kde.org/phonon/html/classPhonon_1_1MediaObject.html#ae0f0ab91c97a1f3495ed9467048bb81a

The choosen value (100) should allow for a fluid scrolling of the
progress element, without having a too small resolution, and
it seems to match the resolution of the gstreamer backend anyway.

BUG: 389907

Test Plan

The time is updated on both the progress bar and the status bar with
both VLC and GStreamer Phonon backends.

Diff Detail

Repository
R344 Juk
Branch
Applications/18.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2443
Build 2461: arc lint + arc unit
ltoscano requested review of this revision.Sep 2 2018, 6:27 PM
ltoscano created this revision.
ltoscano retitled this revision from Set the tick interval, whose defaults value is 0 to Set the tick interval, because the default value is 0.Sep 2 2018, 7:15 PM

Apparently there are two issues on the Phonon backends:

  • phonon-gstreamer works even without setting a default tick interval;
  • when the tick interval is set, phonon-vlc seems to emit the signal twice (at least checking the calls of PlayerManager::slotTick)

As the latter does not seem to impact Juk, it's not important to fix them at the same time, but still they should be investigated.

mpyne accepted this revision.Sep 2 2018, 8:38 PM

I vaguely remember this being required, it probably got dropped in the port to KF5 by accident. I concur with your diagnosis and suggested fix. Please commit!

This revision is now accepted and ready to land.Sep 2 2018, 8:38 PM
ltoscano closed this revision.Sep 2 2018, 8:41 PM