Port scripting to Qt WebEngine

Authored by fvogt on Sep 1 2018, 4:43 PM.



Unfortunately it relies on Qt WebKit features quite intensely, so a few
godawful hacks were necessary to make it work. Most of those are needed
to workaround restrictions of QWebChannel as bridge to the browser page.

We gain:
+ Independence from WebKit
+ Support for newer JS and HTML features in scripts

We lose:

  • Performance (especially memory use)
  • Independence from WebEngine
  • Sanity
Test Plan

Tested the detailed memory info pages on a few processes, info is
correct and the page seems to work fully.

Diff Detail

R111 KSysguard Library
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Sep 1 2018, 4:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 1 2018, 4:43 PM
fvogt requested review of this revision.Sep 1 2018, 4:43 PM
fvogt retitled this revision from RFC: Port scripting to Qt WebEngine to Port scripting to Qt WebEngine.Oct 9 2018, 9:25 AM

I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far.

davidedmundson accepted this revision.Oct 9 2018, 9:36 AM
davidedmundson added a subscriber: davidedmundson.

I don't like the use of any web browser in something so minor...but this is definitely better than the current state.
I say we go for it.

This revision is now accepted and ready to land.Oct 9 2018, 9:36 AM
This revision was automatically updated to reflect the committed changes.