Differential D15209

Port scripting to Qt WebEngine
ClosedPublic
Actions

Authored by fvogt on Sep 1 2018, 4:43 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R111:c9747e37c531: Port scripting to Qt WebEngine

Summary

Unfortunately it relies on Qt WebKit features quite intensely, so a few
godawful hacks were necessary to make it work. Most of those are needed
to workaround restrictions of QWebChannel as bridge to the browser page.

We gain:
+ Independence from WebKit
+ Support for newer JS and HTML features in scripts

We lose:

Performance (especially memory use)
Independence from WebEngine
Sanity

Test Plan

Tested the detailed memory info pages on a few processes, info is
correct and the page seems to work fully.

Diff Detail

Repository

R111 KSysguard Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

fvogt created this revision.Sep 1 2018, 4:43 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 1 2018, 4:43 PM

fvogt requested review of this revision.Sep 1 2018, 4:43 PM

Harbormaster completed remote builds in B2416: Diff 40829.Sep 1 2018, 4:43 PM

I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far.

I don't like the use of any web browser in something so minor...but this is definitely better than the current state.
I say we go for it.

This revision is now accepted and ready to land.Oct 9 2018, 9:36 AM

Closed by commit R111:c9747e37c531: Port scripting to Qt WebEngine (authored by fvogt). · Explain WhyOct 9 2018, 9:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (10 lines)
M			config-ksysguard.h.cmake (4 lines)
M			processui/CMakeLists.txt (4 lines)
M			processui/scripting.h (109 lines)
M			processui/scripting.cpp (180 lines)