At least one test requires the physical size to be set.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:95cb47cae2ae: [platforms/virtual] Set raw physical size of outputs
Lock screen screen edges test is passing again. Without the change the corner
offset in the ScreenEdges class is not calculated correctly via the
physicalDpiX() and physicalDpiY() values of an auxilliary QWidget.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| plugins/platforms/virtual/virtual_output.cpp | ||
|---|---|---|
| 45 | This is in mm. Which gives this virtual screen a DPI of 25.4, it still works but it's a bit unrealistic. Might be better to just set an arbitrary sensible QRect. | |
| plugins/platforms/virtual/virtual_output.cpp | ||
|---|---|---|
| 45 | For the tests it does not make a difference, but yea kind of unrealistic. I will push this here as a quick fix, but we should in the future expand this class in general for better tests of (auto-)scaling. With the new structure this should then translate directly to the DRM backend. | |