Differential D15182

ensure "make install" on windows also installs development header files
ClosedPublic
Actions

Authored by mkoller on Aug 31 2018, 10:56 AM.

Details

Reviewers
None
Group Reviewers
Marble
Commits
R34:d0c59d84a433: ensure "make install" on windows also installs development header files
Summary

The attached change ensures we also get the header files installed.
At least this is what is needed to use the resulting install dir to build a widget using the Marble widget.

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkoller created this revision.Aug 31 2018, 10:56 AM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptAug 31 2018, 10:56 AM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
mkoller requested review of this revision.Aug 31 2018, 10:56 AM
rahn added a subscriber: rahn.Aug 31 2018, 11:04 AM

Looks good to me!

rahn added a comment.Aug 31 2018, 11:05 AM

Have you tested creating a new deployable Windows package? Or did you just test whether compilation on the platform works? :-)

mkoller added a comment.Aug 31 2018, 3:47 PM

Have you tested creating a new deployable Windows package?

no

Or did you just test whether compilation on the platform works? :-)

We are using Marble in our product, and therefore we just package what was installed into a tar file,
which will then later on be extracted into the developers build-tree.
All I tested was if what was installed was enough to create a widget derived from MarbleWidget.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2018, 3:27 PM
Closed by commit R34:d0c59d84a433: ensure "make install" on windows also installs development header files (authored by mkoller). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlib/marble/CMakeLists.txt (14 lines)

Diff 40753

View Options

lib/marble/CMakeLists.txt

Loading...