Add icon names for root level kicker, recent docs, recent apps, power and session
Needs RevisionPublic

Authored by marcusb on Aug 30 2018, 1:13 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

The boolean "showIconsRootLevel" made it possible to show category icons on the root level of the kicker startmenu.
Because of that the categories have icons but the menu entries for recent documents, recent applications and power and session are left without icons.
This fix makes it possible to set icon names for the three missing icons.

Test Plan
  1. set the "showIconsRootLevel" to true in applets/kicker/package/contents/config/main.xml
  2. make sure this has an effect. -> category icons are in front of the entries
  3. see that there are icons missing for recent documents, recent applications and power / session .
  4. set the icons introduced by this fix also in applets/kicker/package/contents/config/main.xml to for example: document-open-recent, tag-recents, system-shutdown) like this:
<entry name="iconNameRecentDocs" type="String">
   <label>The name of the icon to use for the root level recent documents menu entry</label>
   <default>document-open-recent</default>
 </entry>
 <entry name="iconNameRecentApps" type="String">
   <label>The name of the icon to use for the root level recent applications menu entry</label>
   <default>tag-recents</default>
 </entry>
 <entry name="iconNamePowerAndSession" type="String">
   <label>The name of the icon to use for the root level power / session menu entry</label>
   <default>system-shutdown</default>
 </entry>
  1. make sure the change has an effect
  2. icons are present

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2357
Build 2375: arc lint + arc unit
marcusb created this revision.Aug 30 2018, 1:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 30 2018, 1:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
marcusb requested review of this revision.Aug 30 2018, 1:13 PM
marcusb edited the summary of this revision. (Show Details)Aug 31 2018, 7:28 AM
marcusb edited the test plan for this revision. (Show Details)
marcusb edited the test plan for this revision. (Show Details)
marcusb retitled this revision from Add icon names for root level kicker, recent docs, recent apps, power and: session to Add icon names for root level kicker, recent docs, recent apps, power and session.Sep 4 2018, 4:53 AM
hein added a subscriber: hein.Sep 4 2018, 10:34 AM

This is a good patch, but I think it's actually doing too much :). I'd be OK with hardcoding the icon names in the code. I don't think they need to be configurable. Could you simplify the patch?

hein requested changes to this revision.Oct 22 2018, 5:12 AM
This revision now requires changes to proceed.Oct 22 2018, 5:12 AM