Effects are deleted in a deleteLater potentially outside the scope of
our test. Our MockEffectsHandler (which contains the global static
"effects") has the lifespan of the test.
Fixes failing unit test.
zzag |
KWin |
Effects are deleted in a deleteLater potentially outside the scope of
our test. Our MockEffectsHandler (which contains the global static
"effects") has the lifespan of the test.
Fixes failing unit test.
Ran test
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Oh, you already uploaded fix.
Please also change TestScriptedEffectLoader and TestPluginEffectLoader.
Also, maybe we have to reset effects ptr in destructor of EffectsHandler.
Also, I think it would be better to be uniform and create dynamic mock EffectsHandler's in all tests.
Also, I think it would be better to be uniform and create dynamic mock EffectsHandler's in all tests.
Please ignore it (and "TestScriptedEffectLoader and TestPluginEffectLoader" part).
But, I still think it would be a good idea to reset effects in destructor of EffectsHandler.