Differential D15163

Avoid global static for effects
ClosedPublic
Actions

Authored by broulik on Aug 30 2018, 10:50 AM.

Details

Reviewers
aacid
ahartmetz
davidedmundson
Group Reviewers
KWin
Commits
R108:3cfb7a30f005: Avoid global static for effects
R108:0fd939425bf7: Avoid global static for effects
Summary

Otherwise we call i18n without a QCoreApplication

Test Plan

Compiles, builtineffectloader test crashes in

qt_meta_data_QObjectCleanupHandler

but also without this patch.. Investigating

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 30 2018, 10:50 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 30 2018, 10:50 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Aug 30 2018, 10:50 AM
davidedmundson accepted this revision.Aug 30 2018, 10:51 AM
This revision is now accepted and ready to land.Aug 30 2018, 10:51 AM
Closed by commit R108:0fd939425bf7: Avoid global static for effects (authored by broulik). · Explain WhyAug 30 2018, 11:02 AM
This revision was automatically updated to reflect the committed changes.
ltoscano added a subscriber: ltoscano.Aug 30 2018, 11:15 AM

Backport to all supported branches?

broulik added a comment.Aug 30 2018, 11:36 AM
In D15163#317624, @ltoscano wrote:

Backport to all supported branches?

Done

Revision Contents
Changeset List

PathPackages
Meffects/effect_builtins.cpp (22 lines)

Diff 40691

View Options

effects/effect_builtins.cpp

Loading...