Differential D15147

Correctly save behaviourOnLaunch
ClosedPublic
Actions

Authored by davidedmundson on Aug 29 2018, 3:16 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:5f252da8b58e: Correctly save behaviourOnLaunch
Summary

We only wrote out a checkbox value if the checkbox was checked.
Unchecking it would not do anything.

BUG: 398022

Test Plan

Read KRun's exepcted values
Unchecked config option
Reloaded dolphin
Checkbox remained off

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Aug 29 2018, 3:16 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 29 2018, 3:16 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
davidedmundson requested review of this revision.Aug 29 2018, 3:16 PM
ngraham accepted this revision.Aug 29 2018, 7:48 PM
ngraham added a subscriber: ngraham.

Whoops.

Can confirm the problem and that this fixes it. Can't find any regressions with related settings. Thanks!

This revision is now accepted and ready to land.Aug 29 2018, 7:48 PM
elvisangelaccio accepted this revision.Sep 2 2018, 9:14 AM
ngraham added a comment.Sep 3 2018, 10:06 PM

Can we land this on the stable branch please?

Closed by commit R318:5f252da8b58e: Correctly save behaviourOnLaunch (authored by davidedmundson). · Explain WhySep 4 2018, 12:21 PM
This revision was automatically updated to reflect the committed changes.
wbauer added a subscriber: wbauer.Sep 18 2018, 12:58 PM
wbauer added inline comments.
src/settings/general/confirmationssettingspage.cpp
100

Judging from the KIO source code, the possible values for this option seem to be "alwaysAsk", "open" and "execute" though.
See also https://bugs.kde.org/show_bug.cgi?id=371837, that's mentioned there as well.

And if I read the code correctly, "dontAsk" would actually have the same result as "open", not "execute". But the option in dolphin's setting is labelled "Executing scripts or desktop files", so this fix is actually wrong IMHO.

(Ideally dolphin should probably offer all three options in its settings, that's more than a simple bugfix though.)

Revision Contents
Changeset List

Diff 40975

View Options

src/settings/general/confirmationssettingspage.cpp

Loading...