Otherwise it would reject Unix User\foo
Details
(or whatever the part before the backslash is called)
Thanks Fabian for help with regular expressions :)
- I can now enable and disable guest mode again in kdenetwork-filesharing Share dialog and can actually access my shares now (somewhat)
Diff Detail
- Repository
- R241 KIO
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Any chance you can create a unit test?
Will try. Should it just check a couple of strings for validity? And also check that the ACL it read are valid since they must be as they came from net usershare?
For the beginning, a couple of strings which previously failed, and some which are ok before and after, are a good start.
Some input which should be rejected would cover the majority of this functions scope.
Does this patch help with https://bugs.kde.org/show_bug.cgi?id=398079? It just came in today.
I don't know but without this patch I failed to configure permissions in the "Share" tab, e.g. "Allow guest" or "Everyone: full access", so maybe it fixes that.