Guard the calls to removed libraw API so that they are not compiled with 0.19. This patch is intended for the 18.08 branch, it simply drops the libraw calls but keeps the API intact (so the corresponding libkdcraw functions will just not do anything when using 0.19). See D15133 a follow-up revision for master that completely removes the API.
Patch based on digikam commit f5bc69c288dda2509dbdfd9c3c54cd82d88c38ef
Builds against libraw 0.18 and 0.19, gwenview can open and do stuff with RAW pictures.
| Lint Skipped |
| Unit Tests Skipped |
I'd say to use this version, and merge it to master.
As noted in D15133: Drop functionality that depends on libraw features removed in 0.19, this approach IMHO is way safer, and less disruptive for users of libkdcraw (and downstreams too...).
If you want to add deprecation markers for things that will not work with libraw >= 0.19 go for it; otherwise this patch IMHO seems OK.
Thanks, this works fine for me!
@rempt, krita master will need the same fix (unless libkdcraw is being unbundled again).
We cannot unbundle libkdcraw since its maintainer made it into something completely different. I'm fine with merging this patch.