e.g. doMatch for regex stuff will use -1 as skipOffset.
But -1 was not handled at all and you matched again and again.
Details
Details
make && make test works
with patch:
Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 2552ms
- Finished testing of TestHighlighterTest *****
without patch:
Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 3250ms
- Finished testing of TestHighlighterTest *****
perf shows improvements, too, found during some AbsInt internal profiling .P
Diff Detail
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Nice find! And a nice showcase of a contribution we wouldn't have gotten without MIT relicensing I guess :)
Comment Actions
;=)
Yeah, given I can spend now some work-time on profiling things as we start to use the current master for our tools, I hope I can contribute some more things like this.
A colleague has seen a massive slow-down compared to our old highlighter for some internal format and given it just has a few regex rules and a keyword list, this is a bit strange, need to see if this alone solves it.