Kirigami Pages are required for kcms
ClosedPublic

Authored by mart on Aug 28 2018, 11:22 AM.

Details

Summary

adapt to the new multilevel stuff as it's needed for qml kcms to
inherit in some shape Kirigami.Page in order to have a title
this was the only kcm left which wasn't a page.
it needs this change with new frameworks and workspace combination
but old workspace and new frameworks is on as old systemsettings did the title itself

Test Plan

looks the same and still works

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
mart/newkcm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2304
Build 2322: arc lint + arc unit
mart created this revision.Aug 28 2018, 11:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 28 2018, 11:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Aug 28 2018, 11:22 AM
davidedmundson accepted this revision.Aug 28 2018, 11:30 AM
davidedmundson added a subscriber: davidedmundson.

Please fix typo in commit message

This revision is now accepted and ready to land.Aug 28 2018, 11:30 AM
ngraham added inline comments.
src/kcm/package/contents/ui/main.qml
34

If we're moving this text around, let's also correct it: "allows to set up" is not correct grammar. Also, "set up" is not really standard terminology.

Should be "allows you to configure" or "allows configuring"

abetts added a subscriber: abetts.Aug 28 2018, 2:15 PM

I prefer "allows you to configure"

mart retitled this revision from Kirigami ages are required for kcms to Kirigami Pages are required for kcms.Sep 28 2018, 9:19 AM
mart updated this revision to Diff 42466.Sep 28 2018, 9:28 AM
  • fix wording
This revision was automatically updated to reflect the committed changes.