ClosedPublic
Actions

Authored by dcaliste on Aug 27 2018, 2:59 PM.

Details

Reviewers

leinir
danders
boemann

Group Reviewers

Calligra: 3.0

Commits

R8:4ebf41d68d71: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>

Summary

QWeakPointer has been deprecated to store pointers on QObject. QPointer should be used instead.

Diff Detail

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dcaliste created this revision.Aug 27 2018, 2:59 PM

Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptAug 27 2018, 2:59 PM

dcaliste requested review of this revision.Aug 27 2018, 2:59 PM

Propagate changes into filters: missing conversion from QSharedPointer into QPointer.

dcaliste added reviewers: leinir, danders.Aug 29 2018, 12:34 PM

Adding in Camilla, because text :)

I have no fundamentally against it, but I cannot test it right - so if it works 'm all for it

In that case, things build and run fine for me, and while i can't comment on performance here, i understand that making QPointer sufficiently performant was basically why QWeakPointer was deprecated anyway, so... shipit! :)

This revision is now accepted and ready to land.Aug 31 2018, 12:47 PM

Closed by commit R8:4ebf41d68d71: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*> (authored by dcaliste). · Explain WhySep 20 2018, 8:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			filters/sheets/excel/sidewinder/excel.cpp (2 lines)
M			libs/main/KoFilterManager_p.h (4 lines)
M			libs/text/KoList.h (4 lines)
M			libs/text/KoList.cpp (2 lines)
M			libs/text/KoList_p.h (3 lines)
M			libs/text/KoTextDocument.h (4 lines)
M			libs/text/KoTextDocument.cpp (2 lines)
M			libs/text/KoTextEditor_undo.cpp (4 lines)
M			libs/text/KoTextInlineRdf.cpp (8 lines)
M			libs/text/KoTextMeta.cpp (4 lines)
M			libs/text/OdfTextTrackStyles.h (4 lines)
M			libs/text/commands/ChangeTrackedDeleteCommand.h (4 lines)
M			libs/text/commands/ChangeTrackedDeleteCommand.cpp (2 lines)
M			libs/text/commands/DeleteCommand.h (4 lines)
M			libs/text/commands/DeleteCommand.cpp (4 lines)
M			libs/text/commands/InsertDeleteChangesCommand.h (4 lines)
M			libs/text/commands/InsertNoteCommand.h (4 lines)
M			libs/text/commands/RemoveDeleteChangesCommand.h (4 lines)
M			libs/text/commands/TextPasteCommand.h (4 lines)
M			plugins/textshape/TextTool.h (7 lines)
M			plugins/textshape/TextTool.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40513			Aug 27 2018, 2:57 PM	★	★
Diff 2	40514			Aug 27 2018, 3:13 PM	★	★
Diff 3	41965	e4a5dc4	R8:4ebf41d68d71d4241d455649733fa64b11f5d433	Sep 20 2018, 8:30 AM	★	★