Don't hardcode custom icons location
ClosedPublic

Authored by wojnilowicz on Aug 26 2018, 7:54 AM.

Details

Summary

Custom icons aren't visible on MS Windows because path to them is set to install directory. It happens to be that this install directory isn't the directory where KMyMoney searches for icons on MS Windows. This patch intends to search for the icons before it adds them to icons search path. It's untested though.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz requested review of this revision.Aug 26 2018, 7:54 AM
wojnilowicz created this revision.
tbaumgart accepted this revision.Aug 26 2018, 9:58 AM

Looks good to me. We should give it a try and see how the nightly build performs.

kmymoney/kmymoney.cpp
1178

Can we have a warning on the console that our assumption is not correct? I think that would help. Maybe print out the contents of QIcon::themeSearchPaths() or so.

This revision is now accepted and ready to land.Aug 26 2018, 9:58 AM
This revision was automatically updated to reflect the committed changes.