Extend rentalcar support
ClosedPublic

Authored by bport on Aug 24 2018, 10:58 PM.

Details

Summary
  • Add telephone to place based on https://schema.org/Place
  • Add rentalCompany (Organization)
  • Add Brand type, and support it on rentalcar

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Aug 24 2018, 10:58 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 24 2018, 10:58 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
bport requested review of this revision.Aug 24 2018, 10:58 PM
vkrause accepted this revision.Aug 25 2018, 8:33 AM

Thanks! This however will conflict slightly on current master since datatypes.cpp is gone now. See 060e2296a76e99b77dfd67b1b7253178684736b6, the explicit registration is no longer necessary, instead we don't forward-declare property types anymore to make this work automatically (necessary for static builds).

This revision is now accepted and ready to land.Aug 25 2018, 8:33 AM
bport updated this revision to Diff 40441.Aug 25 2018, 6:01 PM

take in consideration feedback

bport updated this revision to Diff 40443.Aug 25 2018, 6:19 PM

Remove uneeded qDebug()

vkrause accepted this revision.Aug 25 2018, 6:25 PM
This revision was automatically updated to reflect the committed changes.