Differential D15041

Simplify the vertices upload code
ClosedPublic
Actions

Authored by ervin on Aug 23 2018, 9:47 PM.

Details

Reviewers
laysrodrigues
tcanabrava
patrickelectric
leandrosantiago
rizzitello
Commits
R231:f1ce2570727d: Simplify the vertices upload code
Summary

No need to spend time in hand-rolled loops, it's just a memcpy at that
point. Also no need to keep a copy of the vertices vector so remove it.

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin requested review of this revision.Aug 23 2018, 9:47 PM
ervin created this revision.
ervin set the repository for this revision to R231 Atelier.Aug 23 2018, 9:55 PM
rizzitello added a comment.Aug 24 2018, 1:22 AM

This will not apply cleanly to master, Please check the base

tcanabrava accepted this revision.Aug 24 2018, 9:20 AM

Seems easy enough to fix any conflict if we hit it.

This revision is now accepted and ready to land.Aug 24 2018, 9:20 AM
laysrodrigues accepted this revision.Aug 25 2018, 12:32 PM
rizzitello accepted this revision.Aug 25 2018, 3:58 PM
Closed by commit R231:f1ce2570727d: Simplify the vertices upload code (authored by ervin). · Explain WhyAug 29 2018, 6:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40612

View Options

src/widgets/3dview/linemeshgeometry.h

Loading...
View Options

src/widgets/3dview/linemeshgeometry.cpp

Loading...