Rename AnimatedEntity to SceneEntity
ClosedPublic
Actions

Authored by ervin on Aug 23 2018, 9:46 PM.

Details

Reviewers

laysrodrigues
tcanabrava
patrickelectric
leandrosantiago
rizzitello

Commits

R231:2fe9b6478261: Rename AnimatedEntity to SceneEntity

Summary

It's not really animated anyway, the name didn't quite make sense with
what it does.

Diff Detail

Repository

R231 Atelier

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin requested review of this revision.Aug 23 2018, 9:46 PM

ervin created this revision.

Harbormaster completed remote builds in B2165: Diff 40323.Aug 23 2018, 9:46 PM

ervin set the repository for this revision to R231 Atelier.Aug 23 2018, 9:53 PM

rizzitello added a reviewer: rizzitello.Aug 23 2018, 10:05 PM

This Diff should be combined with D15031 D15032 D15033 D15034 D15035 D15036 D15037 D15038 D15039 D15040 D15041 D15042 D15043 D15044 D15045 and D15046. This will be easier to review as the change set it is.

In D15030#314461, @rizzitello wrote:

This Diff should be combined with D15031 D15032 D15033 D15034 D15035 D15036 D15037 D15038 D15039 D15040 D15041 D15042 D15043 D15044 D15045 and D15046. This will be easier to review as the change set it is.

No need to. Many developers that use phabricator tend to send one diff as review request, we should be able to review both ways. :)
I don't belive that Kevin needs to rebase everything if he feels that this is easier for him. All of the diffs are self contained.

This revision is now accepted and ready to land.Aug 24 2018, 9:17 AM

laysrodrigues accepted this revision.Aug 25 2018, 12:18 PM

rizzitello accepted this revision.Aug 25 2018, 3:51 PM

Closed by commit R231:2fe9b6478261: Rename AnimatedEntity to SceneEntity (authored by ervin). · Explain WhyAug 29 2018, 6:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
V			src/widgets/3dview/{AnimatedEntity.qml → SceneEntity.qml}
V			src/widgets/3dview/{SceneEntity.qml ← AnimatedEntity.qml}
M			src/widgets/3dview/viewer3d.qml (2 lines)
M			src/widgets/3dview/viewer3d.qrc (2 lines)