Update icons kcm docbook to 5.13
ClosedPublic
Actions

Authored by lueck on Aug 23 2018, 2:36 PM.

Details

Reviewers

Group Reviewers

Plasma
Documentation

Commits

R119:6864d6fee4a2: Update icons kcm docbook to 5.13

Summary

apply chanches from [Icon KCM] Port to new design https://phabricator.kde.org/D12459

Test Plan

checkXML5 index.docbook

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lueck created this revision.Aug 23 2018, 2:36 PM

Restricted Application added projects: Plasma, Documentation. · View Herald TranscriptAug 23 2018, 2:36 PM

Restricted Application added subscribers: kde-doc-english, plasma-devel. · View Herald Transcript

yurchor accepted this revision.Aug 23 2018, 2:39 PM

This revision is now accepted and ready to land.Aug 23 2018, 2:39 PM

I am hoping there is also a way for people to be able to see more information about the theme in GHNS. Is there a visual way that we can do this? Maybe do the layout the same as it was before BUT where the preview image used to be, have the new gallery item look?

In D15024#314116, @abetts wrote:

I am hoping there is also a way for people to be able to see more information about the theme in GHNS. Is there a visual way that we can do this? Maybe do the layout the same as it was before BUT where the preview image used to be, have the new gallery item look?

@abetts: your comment is about GHNS, but what do you want to be changed in this review?

pino added a subscriber: pino.Aug 27 2018, 6:05 PM

pino added inline comments.

doc/kcontrol/icons/index.docbook
48	extra empty line
85–86	typo "to"

fix issues spotted by pino, thanks

Closed by commit R119:6864d6fee4a2: Update icons kcm docbook to 5.13 (authored by lueck). · Explain WhySep 5 2018, 5:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
D	M	(bin)	doc/kcontrol/icons/delete-theme.png
A	M	(bin)	doc/kcontrol/icons/edit-delete.png
A	M	(bin)	doc/kcontrol/icons/edit-undo.png
D	M	(bin)	doc/kcontrol/icons/effects.png
M			doc/kcontrol/icons/index.docbook (273 lines)
D	M	(bin)	doc/kcontrol/icons/install-theme.png
M		(bin)	doc/kcontrol/icons/main.png
D	M	(bin)	doc/kcontrol/icons/size.png
M		(bin)	doc/kcontrol/icons/use-of-icons.png

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40304			Aug 23 2018, 2:34 PM	★	★
Diff 2	40526			Aug 28 2018, 3:43 AM	★	★
Diff 3	41067	b2ae7ec	R119:6864d6fee4a220e7345329363e8511a4b617baa5	Sep 5 2018, 5:37 PM	★	★