Differential D15007

fix failing tests with Qt 5.11
ClosedPublic
Actions

Authored by mgallien on Aug 22 2018, 8:47 PM.

Details

Reviewers
astippich
januz
Commits
R255:f3f4e1ffed76: fix failing tests with Qt 5.11
R255:7f4ac1ebf872: fix failing tests with Qt 5.11
Summary

fix failing tests with Qt 5.11

fix failing tests in random play with Qt 5.11

remove checking for exact index when in random mode because it depends
on Qt behavior that can change

fix failing test: manageaudioplayerTest skipNextTrackWithRandomPlay

Test Plan

tests are all OK with Qt 5.11

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Aug 22 2018, 8:47 PM
mgallien created this revision.
astippich added a comment.Sep 1 2018, 10:33 AM

this fixes the manageaudioplayer and mediaplaylist test, but I'm getting now a failure in the allalbumsmodel test

mgallien updated this revision to Diff 41121.Sep 6 2018, 8:10 PM
  • fix allalbumsmodeltest that was checking the wrong number of albums
This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2018, 5:45 AM
Closed by commit R255:7f4ac1ebf872: fix failing tests with Qt 5.11 (authored by mgallien). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41313

View Options

autotests/allalbumsmodeltest.cpp

Loading...
View Options

autotests/mediaplaylisttest.cpp

Loading...
View Options

src/manageaudioplayer.cpp

Loading...