Given the license of some files is dubious, this allows MIT loving people to install them as files and not bundling them.
Details
Details
make works
make test fails ATM, but that needs more love if that idea is accepted at all.
Diff Detail
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
BTW, slightly related as idea: I think it would be nice to add a function Definition Downloader::setDownloadLocation() or similar that allows to have a custom download location. This would match nicely with Repository::addCustomSearchPath().
data/CMakeLists.txt | ||
---|---|---|
3 | Note: The Ninja generator doesn't like this: CMake Warning (dev): Policy CMP0058 is not set: Ninja requires custom command byproducts to be explicit. Run "cmake --help-policy CMP0058" for policy details. Use the cmake_policy command to set the policy and suppress this warning. This project specifies custom command DEPENDS on files in the build tree that are not specified as the OUTPUT or BYPRODUCTS of any add_custom_command or add_custom_target: data/syntax/css-php.xml data/syntax/html-php.xml data/syntax/javascript-php.xml For compatibility with versions of CMake that did not have the BYPRODUCTS option, CMake is generating phony rules for such files to convince 'ninja' to build. Project authors should add the missing BYPRODUCTS or OUTPUT options to the custom commands that produce these files. This warning is for project developers. Use -Wno-dev to suppress it. There must be a way to implement this feature and keep using add_custom_command...? Using execute_process() is usually a bad sign (tm). Note that these commands will be executed each CMake run(!) |