Differential D15001

Add CalDAV & CardDav URLs in "Google" account
ClosedPublic
Actions

Authored by rnicole on Aug 22 2018, 2:21 PM.

Details

Reviewers
cmollekopf
Maniphest Tasks
T9490: Figure out how Google's CardDAV server works
Commits
R162:8c4b45f6448f: Add CalDAV & CardDav URLs in "Google" account
Summary
  • Calendar works perfectly
  • From the logs, CardDav finds the right address books, but nothing is displayed on the contact view
  • Renamed the "GMail" account to "Google"

Diff Detail

Repository
R162 Kube
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rnicole requested review of this revision.Aug 22 2018, 2:21 PM
rnicole created this revision.
cmollekopf added a comment.Aug 22 2018, 3:11 PM

great =)
Let's figure out why carddav doesn't work and rename in the Ui only to Google.

rnicole updated this revision to Diff 40279.Aug 23 2018, 7:26 AM
rnicole retitled this revision from Add CalDAV & CardDav URLs in "GMail" account to Add CalDAV & CardDav URLs in "Google" account.
rnicole edited the summary of this revision. (Show Details)

Renamed the "GMail" account to "Google". It seems that those who already have a Google account can remove their account from the command-line only, and then add it again from Kube

cmollekopf added a comment.Aug 23 2018, 7:48 AM
In D15001#313863, @rnicole wrote:

Renamed the "GMail" account to "Google". It seems that those who already have a Google account can remove their account from the command-line only, and then add it again from Kube

rename in the Ui only to Google. Please revert all the renaming changes.

cmollekopf added a comment.Aug 23 2018, 7:52 AM

Sorry if I wasn't clear enough in the first message.

The user visible strings are in:

  • accounts/google/metadata.json
  • accounts/gmail/qml/AccountSettings.qml
rnicole updated this revision to Diff 40294.Aug 23 2018, 11:22 AM

Revert and rename only in the UI

cmollekopf accepted this revision.Aug 24 2018, 8:56 AM
This revision is now accepted and ready to land.Aug 24 2018, 8:56 AM
Closed by commit R162:8c4b45f6448f: Add CalDAV & CardDav URLs in "Google" account (authored by rnicole, committed by cmollekopf). · Explain WhyAug 24 2018, 8:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40356

View Options

accounts/gmail/gmailsettings.cpp

Loading...
View Options

accounts/gmail/metadata.json

Loading...
View Options

accounts/gmail/qml/AccountSettings.qml

Loading...