BUG: 220976
Details
- Reviewers
dfaure broulik ngraham cfeck - Group Reviewers
Frameworks - Commits
- R241:9e706796b152: Display mounted file system type and mounted from fields in properties dialog
Open properties dialog.
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/widgets/kpropertiesdialog.cpp | ||
---|---|---|
1161 | Captailize: File System | |
1164 | This leaks, you can probably create it on the stack: QStorageInfo storageInfo(...); Also, shouldn't you pass url.toLocalFile() instead of hardcoded /? | |
1169 | QString::fromLatin1? |
Let's move the new "Mounted from:" code to within the conditional that determines whether or not to show "Mounted on:". We should show both or neither, not just one.
Works great and looks fine to me, and the code seems sensible too given that this dialog is currently implemented with a GridLayout. I'd like to see this ported to use a FormLayout at some point, which is both more semantically appropriate, and would also simplify this type of code. But that's material for another patch of course. :)
Please wait for at least one more review before landing.