[Windows Device] Show device label only if there is one
ClosedPublic

Authored by broulik on Aug 22 2018, 10:20 AM.

Details

Summary

Avoids showing C: () for drives without a label

Test Plan

solid-hardware5.exe details /org/kde/solid/win/volume/disk#0.partition#1 output correctly showed

description = 'C:' (string)

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 22 2018, 10:20 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 22 2018, 10:20 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Aug 22 2018, 10:20 AM
broulik retitled this revision from Show device label only if there is one to [Windows Device] Show device label only if there is one.Aug 22 2018, 10:50 AM
vonreth accepted this revision.Aug 23 2018, 6:56 AM

Sounds sane

This revision is now accepted and ready to land.Aug 23 2018, 6:56 AM
This revision was automatically updated to reflect the committed changes.