After rework of the capture module creation flats creation works again.
BUGS: 397650
Details
Details
Create a sequence with flats and set the calibration to a certain ADU value
to force calibration. Flats should be created with the defined ADU value
within the given range.
A new test for testing flats creation has been aded to Tests/scheduler. Run
this test and check whether three new flats have been created.
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
As a hotfix, ok. On the long term, we should avoid isPreview when dealing with calibration. I'll test tonight.
Comment Actions
Bugfix for #397650 flat creation failed (Update)
Separation of pure preview job from flat calibration preview now by calibration stage
Comment Actions
Oops, that was not the intention! I did a rebase in advance, so this small change includes a bunch of other changes. The only relevant change is that to capture.cpp.
Please advise: what should I do to carve it out?
Comment Actions
From what I see the other changes are from master right? If you have a local master, make sure its upstream is origin/master, set the upstream of bugfix_397650_creating_flats_failed to master, pull changes to your local master (from origin/master) then pull changes to your development branch (from master). Then arc diff the result.
Comment Actions
Even in this state, I suppose it would merge anyway. Unless you have other changes scattered in that I did not see?
Comment Actions
The only changes I made were in capture.cpp - in addition to the new test case. The diff of my changes is attached.
Comment Actions
Yes, another way to do it:
$ git checkout master
$ git branch -set-upstream-to=origin/master
$ git pull
$ git cherry-pick 941bcd65a0ca
$ arc diff --update D14977
Comment Actions
If you want your neat phabricator commit message to be visible in the git log, I suggest you squash your two commits. If Jasem fuses the diff now, only the last commit message will appear.
Comment Actions
Bugfix for #397650 flat creation failed Summary: After rework of the capture module creation flats creation works again. BUGS: 397650 Test Plan: Create a sequence with flats and set the calibration to a certain ADU value to force calibration. Flats should be created with the defined ADU value within the given range. A new test for testing flats creation has been aded to Tests/scheduler. Run this test and check whether three new flats have been created. Reviewers: TallFurryMan Subscribers: kde-edu Tags: #kde_edu Differential Revision: https://phabricator.kde.org/D14977
Comment Actions
Fix is tested OK for me. Sorry for taking such a long time, the parking states fix was a headache :)