| leinir | |
| danders |
| Calligra: 3.0 |
Change deprecated function calls to QRectF::intersect() for QRectF::intersected().
(Very minor patch, to get use to Phabricator, I've got some changes not to use obsolate functions from QAbstractItemModel that will come later, or do you prefer to make them goes to the same commit ?)
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
@anthonyfieroni Ok, will update the diff with other replacements of obsolete functions.
I've added replacements for QAbstractItemModel::reset(). This allow to "lock" the model during the reset. So I've tried to put the beginResetModel() before the change of the private members, and the endResetModel() after.
I'm not 100% sure of stackChanged() change.
Probably ok, but the original would call both begin and end before calling the selection model.
To get exactly the same behaviour you could do the same.
It depends on how the selction model handles reset and setCurrentIndex() I guess.
Hmm, I think I would call both begin and end before setCurrentIndex() as setCurrentIndex() usually emits signals that may prompt consumers to access the model.
@danders I agree with your remark, I was wondering exactly the same. It's safer to put the begin / end together. I'll update the diff and add a comment to suggest to move the end after the setCurrentIndex() after extensive testing.
Update the patch in stackChanged() call to have the exact behaviour than before in this method.