Differential D14970

[MPris Dataengine] Avoid blocking calls in media shortcuts handling
ClosedPublic
Actions

Authored by broulik on Aug 21 2018, 9:22 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:eac5d2e40e1e: [MPRIS Data Engine] Avoid blocking calls in media shortcuts handling
Summary

All the information we need (player capabilities and playback status) is already present and managed by the PlayerContainer

BUG: 397685
FIXED-IN: 5.13.5

Test Plan

Started VLC, ran killall -SIGSTOP vlc, pressed "Pause" on my keyboard, plasma would no longer freeze
Back, forward, pause keys still work fine

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 21 2018, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 21 2018, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 21 2018, 9:22 AM
davidedmundson accepted this revision.Aug 23 2018, 2:22 PM
This revision is now accepted and ready to land.Aug 23 2018, 2:22 PM
Closed by commit R120:eac5d2e40e1e: [MPRIS Data Engine] Avoid blocking calls in media shortcuts handling (authored by broulik). · Explain WhyAug 23 2018, 2:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40305

View Options

dataengines/mpris2/multiplexedservice.cpp

Loading...
View Options

dataengines/mpris2/playercontrol.h

Loading...