Differential D14952

Fix includedDefinitions, handle definition change in context switch
ClosedPublic
Actions

Authored by cullmann on Aug 20 2018, 3:52 PM.

Details

Reviewers
vkrause
dhaumann
Commits
R216:612343c96543: handle context switch attributes of the contexts themself
R216:9cfb8fa9a684: Fix includedDefinitions, handle definition change in context switch…
Summary

Fix includedDefinitions, handle definition change in context switch.
They were missing, see PHP/HTML.
I cleaned up the code a bit to just use QVector, no need for a queue, the order is anyways arbitrary (but stable).

BUG: 397659

Test Plan

make && make test

https://bugs.kde.org/show_bug.cgi?id=397659 works now

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Aug 20 2018, 3:52 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 20 2018, 3:52 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Aug 20 2018, 3:52 PM
cullmann added a comment.Aug 20 2018, 3:55 PM

kate *.* in the autotests/input folder works now without any crash, too.

vkrause accepted this revision.Aug 20 2018, 4:40 PM
This revision is now accepted and ready to land.Aug 20 2018, 4:40 PM
ngraham edited the summary of this revision. (Show Details)Aug 20 2018, 4:55 PM
Closed by commit R216:9cfb8fa9a684: Fix includedDefinitions, handle definition change in context switch… (authored by cullmann). · Explain WhyAug 20 2018, 5:02 PM
This revision was automatically updated to reflect the committed changes.
dhaumann added a comment.Aug 20 2018, 5:19 PM

Looks ok to me. Only thing is: with takeLast() you now changed the order of the IncludedDefinitions compared to the previous version. This is of course ok, but in the color config dialog the order is now different than before. Whatever this means... I liked that Modelines and Alert were rather late in the list - on the other hand that was not guaranteed before either... ;)

cullmann added a comment.Aug 20 2018, 5:24 PM

If we want a nice order, we should sort them at the end like the repo does.

cullmann reopened this revision.Aug 21 2018, 10:42 AM

I got told that I missed some more ContextSwitch variants.

This revision is now accepted and ready to land.Aug 21 2018, 10:42 AM
Closed by commit R216:612343c96543: handle context switch attributes of the contexts themself (authored by cullmann). · Explain WhyAug 21 2018, 2:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40158

View Options

autotests/syntaxrepository_test.cpp

Loading...
View Options

src/lib/definition.cpp

Loading...