This changeset silences the gcc warning for the case fall-through.
No idea if this will work for msvc, but that doesn't change much compared to the previous state.
C++17 can use "fallthrough;" to specify an execution path that intentionally falls through the following case.
Details
Details
Without this change, gcc issues a warning on the case fall-through in function unParkMount.
With this change fall-through is acknlowledged and the warning doesn't appear.
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think you want to be using Q_FALLTHROUGH which uses the proper compiler attribute if available
Comment Actions
Q_FALLTHROUGH() was introduced in Qt 5.8, but kstars supports Qt >= 5.4.0. Building on Raspbian Stretch (Debian 9) fails.
Comment Actions
Oh well. I don't think having a #ifdef there will be that nice. Please revert that change.