Warn on logout screen when another user is logged in
ClosedPublic

Authored by broulik on Aug 17 2018, 6:46 PM.

Details

Summary

Since we have a unified screen for logging out and shutting down, the hint is always shown as the user could click on "Logout" but then shut down anyway.

Test Plan


Should we show the name(s) of the other user(s), with avatar? But that could easily clutter up the view? It's quite an edge-case anyway.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 17 2018, 6:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 17 2018, 6:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 17 2018, 6:46 PM

Big +1 for the concept. Only one string change proposal, down below:

lookandfeel/contents/logout/Logout.qml
147

How about also adding something that reinforces why there's a risk. How about this:

"One other user is currently logged in. If the computer shut down or rebooted, that user may lose work."

When do we want unused sessions?

When do we want unused sessions?

Not sure. Does it recycle them or discard them after a while? They keep piling up usually ..

mart added a subscriber: mart.Aug 20 2018, 8:49 AM

to expand on the concept, maybe could be nice as well a kauthorized key to actually letting only logout when there is somebody else logged in

harmathy accepted this revision.Aug 20 2018, 9:16 AM
This revision is now accepted and ready to land.Aug 20 2018, 9:16 AM
broulik updated this revision to Diff 40042.Aug 20 2018, 10:34 AM
broulik edited the test plan for this revision. (Show Details)
  • Update wording
ngraham accepted this revision.Aug 20 2018, 10:58 AM

+1 shipit!

In D14905#311825, @mart wrote:

to expand on the concept, maybe could be nice as well a kauthorized key to actually letting only logout when there is somebody else logged in

That would be appropriate for non-admin users, but I feel fairly strongly that admin users should always be able to shut down and reboot the computer when other users are logged in. They're admins, after all, and should presumably know best.

This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Aug 20 2018, 2:40 PM

This makes good sense in that admin world, more business style. I think they would appreciate it. I would probably look for a string that is a little shorter.