Fix blocklayout unittest after percentage lineheight was fixed in D9537
ClosedPublic

Authored by danders on Aug 17 2018, 12:41 PM.

Details

Summary

There is a couple of failing tests now marked as XFAIL.
I am afraid these are new bugs, but I may have missed something (I hope)

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders created this revision.Aug 17 2018, 12:41 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptAug 17 2018, 12:41 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
danders requested review of this revision.Aug 17 2018, 12:41 PM

Thanks, i really don't know how to change predefined values like 28.0 etc. i see you changed them i still not clear to me what are the new vales :)

libs/textlayout/tests/TestBlockLayout.cpp
497

Can you use macro again?

danders marked an inline comment as done.Aug 17 2018, 1:17 PM

What to change depends on what the number means ;)
Well in general all numbers that depends on fontsize should be changed, the rest should stay the same, but yes it is a puzzle.

boemann accepted this revision.Aug 31 2018, 8:25 AM

I like what you have done - you seem to understand the concepts, so please commit when you feel like it's working

libs/textlayout/tests/TestBlockLayout.cpp
333–334

yes I think so

This revision is now accepted and ready to land.Aug 31 2018, 8:25 AM
This revision was automatically updated to reflect the committed changes.