Differential D14899

[KUrlComboBox] Fix KIcon porting error
ClosedPublic
Actions

Authored by broulik on Aug 17 2018, 11:11 AM.

Details

Reviewers
dfaure
ngraham
Commits
R241:64ba67d0acc4: [KUrlComboBox] Fix KIcon porting error
Summary

It should be using QIcon::fromTheme

Test Plan

I don't actually know where this icon is used but that part showed up in the profiler trying to load pixmaps from the file system and failing

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 17 2018, 11:11 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 17 2018, 11:11 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Aug 17 2018, 11:11 AM
dfaure accepted this revision.Aug 17 2018, 11:14 AM
This revision is now accepted and ready to land.Aug 17 2018, 11:14 AM
ngraham accepted this revision.Aug 17 2018, 11:14 AM
ngraham added a subscriber: ngraham.

Whoops

Closed by commit R241:64ba67d0acc4: [KUrlComboBox] Fix KIcon porting error (authored by broulik). · Explain WhyAug 17 2018, 11:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kurlcombobox.cpp (2 lines)

Diff 39914

View Options

src/widgets/kurlcombobox.cpp

Loading...