InlineNote: Pimpl inline note data without allocs
ClosedPublic

Authored by dhaumann on Aug 17 2018, 10:43 AM.

Details

Summary

Hide more implementation details and make InlineNote more extensible.

Test Plan

make && make test

Diff Detail

Repository
R39 KTextEditor
Branch
inline-note-data (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1940
Build 1958: arc lint + arc unit
dhaumann created this revision.Aug 17 2018, 10:43 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 17 2018, 10:43 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Aug 17 2018, 10:43 AM
cullmann requested changes to this revision.Aug 17 2018, 10:49 AM

I think that is ok, but one should remove column(), isValid() and == (which is no equal anyways ATM).

This revision now requires changes to proceed.Aug 17 2018, 10:49 AM
dhaumann updated this revision to Diff 39909.Aug 17 2018, 10:58 AM
  • Cleanup InlineNote interface
dhaumann updated this revision to Diff 39910.Aug 17 2018, 11:00 AM
  • Remove default constructor, not implemented anyways
cullmann accepted this revision.Aug 17 2018, 11:02 AM
This revision is now accepted and ready to land.Aug 17 2018, 11:02 AM
dhaumann updated this revision to Diff 39911.Aug 17 2018, 11:05 AM
  • Rename InlineNote::hasFocus() to underMouse()
This revision was automatically updated to reflect the committed changes.
brauch added a subscriber: brauch.Aug 17 2018, 11:07 AM

Looks ok to me, except one thing: the operator== is used to compare a note from the list to the "currently active" note in the view. If this compares also the "under mouse" state, this code might be broken now ...?

Can you annotate the code here that you think is wrong?

Sorry, never mind -- that code I removed yesterday. All should be fine.