Optional argument never provided. Cleanup.
ClosedPublic

Authored by svuorela on Aug 16 2018, 3:55 PM.

Diff Detail

Repository
R87 PIM: KTNEF
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
svuorela created this revision.Aug 16 2018, 3:55 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 16 2018, 3:55 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
svuorela requested review of this revision.Aug 16 2018, 3:55 PM
vkrause accepted this revision.Aug 16 2018, 7:15 PM
This revision is now accepted and ready to land.Aug 16 2018, 7:15 PM

+2 for me too
but "Add a couple of alternative keys" where do you find theses infos ?
Could you add it in a readme for example ?

How do you tested it ?

+2 for me too
but "Add a couple of alternative keys" where do you find theses infos ?
Could you add it in a readme for example ?

I have one file that it didn't read that i'm slowly getting more and more info out of. But I only have one dataset. That I can't share.
I have also written a message dumper to dump the parsed content to stdout.. I will submit that a bit later.

How do you tested it ?

I read the resulting ical output of the formatter, and it looks better. Still not perfect.

This revision was automatically updated to reflect the committed changes.