Differential D14884

Make the pdfdocumenttest pass without Poppler
ClosedPublic
Actions

Authored by heikobecker on Aug 16 2018, 3:34 PM.

Details

Reviewers
vkrause
Commits
R1003:7af8526819ec: Make the pdfdocumenttest pass without Poppler
Summary

Make the pdfdocumenttest pass without Poppler

It fails otherwise because PdfDocument::fromData returns a nullptr
in the #else branch of #ifdef HAVE_POPPLER.

Test Plan

pdfdocumenttest passes with and without Poppler

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Aug 16 2018, 3:34 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 16 2018, 3:34 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
heikobecker requested review of this revision.Aug 16 2018, 3:34 PM
heikobecker updated this revision to Diff 39870.Aug 16 2018, 3:37 PM

Remove unrelated commit

heikobecker retitled this revision from Use QTEST_GUILESS_MAIN to Make the pdfdocumenttest pass without Poppler.Aug 16 2018, 3:37 PM
heikobecker edited the summary of this revision. (Show Details)
vkrause accepted this revision.Aug 16 2018, 3:41 PM
This revision is now accepted and ready to land.Aug 16 2018, 3:41 PM
Closed by commit R1003:7af8526819ec: Make the pdfdocumenttest pass without Poppler (authored by heikobecker). · Explain WhyAug 16 2018, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/pdfdocumenttest.cpp (2 lines)

Diff 39871

View Options

autotests/pdfdocumenttest.cpp

Loading...