Read UDS entry times directly and pretty-print on-demand
ClosedPublic

Authored by broulik on Aug 16 2018, 2:22 PM.

Details

Summary

This avoids creating a QDateTime object with all the timezone processing that comes with it since we're only interested in the actual pretty date once we show the role to the user.

Test Plan
  • Similar to D14394
  • Noticed that creation time wasn't pretty-printed, addressed by D14878
  • Saves 8ms opening a folder with 500+ files
  • Dates still show correctly

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 16 2018, 2:22 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 16 2018, 2:22 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Aug 16 2018, 2:22 PM
broulik retitled this revision from Read USD entry times directly and pretty-print on-demand to Read UDS entry times directly and pretty-print on-demand.
dfaure accepted this revision.Aug 18 2018, 11:33 AM
This revision is now accepted and ready to land.Aug 18 2018, 11:33 AM
This revision was automatically updated to reflect the committed changes.